Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize circom frontend #101

Merged
merged 19 commits into from
May 28, 2024
Merged

Stabilize circom frontend #101

merged 19 commits into from
May 28, 2024

Conversation

dmpierre
Copy link
Collaborator

This PR aims at stabilizing sonobe's circom frontend. To do this we:

  1. Fixed the allocation of our IVC inputs when using circom-compat. A PR on a circom-compat fork has been opened here to choose how our IVC inputs are allocated (as witnesses and public inputs) and to adjust circom's R1CS indexes when wrapped by our AugmentedFCircuit.
  2. Disabled default reading of circom's wire mapping when loading R1CS files - as what is being done by circom-compat.
  3. Added a test using a previously non-working circuit; the R1CS of keccak.

@dmpierre dmpierre force-pushed the fix/circom-frontend branch from 2d7b897 to 99e7aac Compare May 23, 2024 12:04
@dmpierre dmpierre marked this pull request as ready for review May 23, 2024 12:08
@dmpierre dmpierre requested a review from arnaucube May 23, 2024 12:08
arnaucube
arnaucube requested changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@arnaucube arnaucube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!!! Great job! 🙌

Tomorrow I'll try to use it in some other external circom projects, but it looks great so far!

folding-schemes/src/frontend/circom/test_folder/keccak256-circom/circuits/keccak.circom Outdated Show resolved Hide resolved
@dmpierre dmpierre requested a review from arnaucube May 28, 2024 11:50
@dmpierre dmpierre requested a review from arnaucube May 28, 2024 13:50
arnaucube
arnaucube approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@arnaucube arnaucube left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!! Great work! 🚀
Big milestone fixing it! Now we can fully fodl Circom circuits ^^

@dmpierre dmpierre added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit da4ab5c May 28, 2024
5 checks passed
@dmpierre dmpierre deleted the fix/circom-frontend branch May 28, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaucube arnaucube arnaucube approved these changes

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmpierre @arnaucube